feat: add extra components from pgm #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaapschoutenalliander <[email protected]>
Signed-off-by: jaapschoutenalliander <[email protected]>
Thijss
reviewed
Oct 1, 2025
Signed-off-by: jaapschoutenalliander <[email protected]>
Signed-off-by: jaapschoutenalliander <[email protected]>
|
Thijss
reviewed
Oct 22, 2025
|
|
||
| """Imports all the arrays, so that array can be imported as follows: | ||
| from power_grid_model_ds._core.model.arrays import MyArray | ||
| """ |
Member
There was a problem hiding this comment.
Do we want to extend the SourceArray too? https://power-grid-model.readthedocs.io/en/stable/user_manual/components.html#id21
Member
Author
There was a problem hiding this comment.
What do you mean? The SourceArray is already supported right?
Member
There was a problem hiding this comment.
we are currently missing a few defaulted input values compared to the PGM docs, or am I mistaken?
Member
There was a problem hiding this comment.
Perhaps easier to leave out the columns with defaults for GenericBranch after all? That way we are consistent across arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #45
This pull request introduces new data types and array classes for asymmetric lines and current sensors, as well as a generic branch type, to the power grid model codebase.